Description

Fixes a Node watch-mode compatibility issue in the TypeScript SDK heartbeat worker. Newer Node worker reload/watch behaviour can emit internal worker-thread messages such as watch:require and watch:import through the normal message event, see nodejs/node#62368.

The heartbeat controller previously assumed every worker message was a heartbeat log message and dynamically dispatched this.logger[message.type](message.message), which can fail for those internal messages.

For internal I used a much simpler fix via yarn patch, please let me know if that's something you prefer instead, happy to update the PR.

diff --git a/clients/dispatcher/heartbeat/heartbeat-controller.js b/clients/dispatcher/heartbeat/heartbeat-controller.js
index 246cb771d0beeb1d5ecaffb0c28bd5ebfb145c9e..32e9b0f6a4eff21649f27888d6374289a2727c3e 100644
--- a/clients/dispatcher/heartbeat/heartbeat-controller.js
+++ b/clients/dispatcher/heartbeat/heartbeat-controller.js
@@ -45,7 +45,7 @@ class Heartbeat {
                     },
                 });
                 this.heartbeatWorker.on('message', (message) => {
-                    this.logger[message.type](message.message);
+                    this.logger[message.type]?.(message.message);
                 });
             }
         });

Similar problem was also encounter in other projects, e.g. https://redirect.github.com/pinojs/thread-stream/pull/213

Type of change

• Bug fix (non-breaking change which fixes an issue)

What's Changed

• Added zod schema for heartbeat messages
• Added runtime guard based on the schema

Checklist

Changes have been:

• Tested (unit tests and manually)
• Linted and formatted
• Documented (where applicable)
• Added to CHANGELOG (where applicable) -- see Keep a Changelog

Testing

• Tested with AI-generated units test that were subsequently deleted to comply with the AI policy
• Manually using yarn link in an affected project.